feat(ingest/cli): add undo soft delete command #11740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
|
Hello @anshbansal 😄 Thank you so much for opening a pull request!
|
hsheth2
approved these changes
Oct 29, 2024
| urn=urn, run_id=run_id, deletion_timestamp=deletion_timestamp, delete=True | ||
| ) | ||
|
|
||
| def change_soft_delete_status( |
There was a problem hiding this comment.
Suggested change
| def change_soft_delete_status( | |
| def set_soft_delete_status( |
There was a problem hiding this comment.
will incorporate
| def change_soft_delete_status( | ||
| self, | ||
| urn: str, | ||
| delete: bool, |
There was a problem hiding this comment.
Suggested change
| delete: bool, | |
| deleted: bool, |
There was a problem hiding this comment.
delete is correct here
| @click.option("--urn", required=True, type=str, help="the urn of the entity") | ||
| def undo_by_filter(urn: str) -> None: | ||
| """ | ||
| Allows to un-soft delete by filters |
There was a problem hiding this comment.
Suggested change
| Allows to un-soft delete by filters | |
| Undo a soft deletion of an entity. |
There was a problem hiding this comment.
will incorporate
anshbansal
added
the
merge-pending-ci
|
OpenAPI ingestion failure is unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist